fix: disable node-externals for dev mode (#5414)

nuxt · Mar 31, 2019 · a5a1657 · a5a1657
1 parent 159123f
commit a5a1657
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/packages/webpack/src/config/server.js b/packages/webpack/src/config/server.js
@@ -29,12 +29,6 @@ export default class WebpackServerConfig extends WebpackBaseConfig {
       }
     }
 
-    // Bundle vue js for avoiding single shared Vue instance
-    const { runInNewContext } = this.buildContext.options.render.bundleRenderer
-    if (runInNewContext === true) {
-      whitelist.push('vue')
-    }
-
     return whitelist
   }
 
@@ -94,7 +88,7 @@ export default class WebpackServerConfig extends WebpackBaseConfig {
     // https://webpack.js.org/configuration/externals/#externals
     // https://github.com/liady/webpack-node-externals
     // https://vue-loader.vuejs.org/migrating.html#ssr-externals
-    if (!this.buildContext.buildOptions.standalone) {
+    if (!this.dev && !this.buildContext.buildOptions.standalone) {
       this.buildContext.options.modulesDir.forEach((dir) => {
         if (fs.existsSync(dir)) {
           config.externals.push(