Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8: use native Python for altered search path workaround in NVDAHelper module #10385

Closed
LeonarddeR opened this issue Oct 15, 2019 · 4 comments
Labels
Python 3.8 Issues or ideas that can be resolved or derive solutions via Python 3.8.

Comments

@LeonarddeR
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

de NVDAHelper module loads the NVDAHelper library with an altered search path.

Describe the solution you'd like

Python 3.8 has add_dll_directory and exposes the winmode parameter, so we should be able to do this natively now.

Describe alternatives you've considered

Leave as is

@LeonarddeR LeonarddeR added the Python 3.8 Issues or ideas that can be resolved or derive solutions via Python 3.8. label Oct 15, 2019
@josephsl
Copy link
Collaborator

Hi,

A variant of this (a new issue) is seen with libluis.dll.

Thanks.

@Adriani90
Copy link
Collaborator

@LeonarddeR is this still relevant?

@Adriani90
Copy link
Collaborator

@josephsl, @seanbudd is this issue still relevant? Or can it be closed?

@josephsl
Copy link
Collaborator

Hi,

This is superseded by Python 3.11 upgrade work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python 3.8 Issues or ideas that can be resolved or derive solutions via Python 3.8.
Projects
None yet
Development

No branches or pull requests

3 participants