Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using self compiled releases of Python 3.7 to keep uptodate with the security fixes. #12875

Closed
lukaszgo1 opened this issue Sep 24, 2021 · 5 comments
Labels
maintenance/dependencyUpdate Maintenance of NVDA, specifically dependency updates. needs-technical-investigation A technical investigation is required to progress the issue. security triaged Has been triaged, issue is waiting for implementation.

Comments

@lukaszgo1
Copy link
Contributor

Briefly discussed in #12064

Is your feature request related to a problem? Please describe.

At the moment NVDA is compiled with Python 3.7 and cannot be updated to more recent version of Python due to this libFFI bug. While Python 3.7 receives security fixes until 2023.06 (Python 3.7 release schedule) new versions are not available as a binary copies so NVDA is stuck on the latest binary release 3.7.9.

Describe the solution you'd like

To be able to take advantage of the security fixes introduced in more recent releases of Python 3.7 I would like to propose to compile later releases ourselves on AppVeyour and use them to build NVDA.
In addition to improving security this would also make upgrading to Python 3.8+ less urgent.

Describe alternatives you've considered

Update to more recent version of Python either when bug in libFFI is fixed or by moving affected code paths to C++.

Additional context

None

@seanbudd
Copy link
Member

What would the compile times look like on AppVeyor?

Could AppVeyor be asked to support the latest Python 3.7 self compiled security releases? Or another build system used?

@lukaszgo1
Copy link
Contributor Author

What would the compile times look like on AppVeyor?

Hard to say without testing but assuming that we would compile an installer once and then for every build just install from the ready .msi package I hope it would not be much longer then what we have now.

Could AppVeyor be asked to support the latest Python 3.7 self compiled security releases? Or another build system used?

I've no idea about this one however compiling ourselves has additional advantage namely that contributors can use the same binary on their systems.

@dpy013
Copy link
Contributor

dpy013 commented Sep 14, 2022

@feerrenrut feerrenrut added triaged Has been triaged, issue is waiting for implementation. needs-technical-investigation A technical investigation is required to progress the issue. security maintenance/dependencyUpdate Maintenance of NVDA, specifically dependency updates. labels Sep 15, 2022
@LeonarddeR
Copy link
Collaborator

I think we can consider closing this given:

  • The bug in libFFI has been fixed
  • It is planned to incorporate this update of libFFI into new versions of Python 3.11.x

@seanbudd
Copy link
Member

Closing this as won't fix

@seanbudd seanbudd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance/dependencyUpdate Maintenance of NVDA, specifically dependency updates. needs-technical-investigation A technical investigation is required to progress the issue. security triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests

5 participants