Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2099 made some changes to ui #2137

Open
max397574 opened this issue Aug 18, 2022 · 5 comments
Open

#2099 made some changes to ui #2137

max397574 opened this issue Aug 18, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@max397574
Copy link
Contributor

Description

There were some changes with #2099 which made the ui look different

Neovim version

NVIM v0.8.0-dev
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version

macOS

Telescope version / branch / rev

latest telescope master

checkhealth telescope

telescope: require("telescope.health").check()
========================================================================
## Checking for required plugins
  - OK: plenary installed.
  - OK: nvim-treesitter installed.

## Checking external dependencies
  - OK: rg: found ripgrep 13.0.0
  - OK: fd: found fd 8.2.1

## ===== Installed extensions =====

## Telescope Extension: `emoji`
  - INFO: No healthcheck provided

## Telescope Extension: `fzf`
  - INFO: No healthcheck provided

Steps to reproduce

open telescope and search for something and then for something that will give no results

Expected behavior

Screenshot 2022-08-18 at 14 03 59
Screenshot 2022-08-18 at 14 01 56

Actual behavior

Screenshot 2022-08-18 at 14 00 25
Screenshot 2022-08-18 at 14 00 38

Minimal config

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
    require("packer").startup({
        {
            "wbthomason/packer.nvim",
            {
                "nvim-telescope/telescope.nvim",
                requires = {
                    "nvim-lua/plenary.nvim",
                    { "nvim-telescope/telescope-fzf-native.nvim", run = "make" },
                },
            },
        },
        config = {
            package_root = package_root,
            compile_path = install_path .. "/plugin/packer_compiled.lua",
            display = { non_interactive = true },
        },
    })
end
_G.load_config = function()
    local actions_layout = require("telescope.actions.layout")
    local themes = require("telescope.themes")
    require("telescope").setup(themes.get_ivy({
        defaults = {},
    }))
    require("telescope").load_extension("fzf")
    require("telescope").setup(themes.get_ivy({
        defaults = {
            selection_caret = "",
        },
    }))
    require("telescope").load_extension("fzf")

    -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
end
if vim.fn.isdirectory(install_path) == 0 then
    print("Installing Telescope and dependencies.")
    vim.fn.system({
        "git",
        "clone",
        "--depth=1",
        "https://github.com/wbthomason/packer.nvim",
        install_path,
    })
end
load_plugins()
require("packer").sync()
vim.cmd(
    [[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]]
)
@max397574 max397574 added the bug Something isn't working label Aug 18, 2022
@fdschmidt93
Copy link
Member

@codegangsta is this something you would be happy to take a look at? :)

@codegangsta
Copy link
Contributor

Sure, I can take a look at this one tonight

@fdschmidt93
Copy link
Member

Thanks! Feel free to ping me in case you have any questions.

@bluz71
Copy link

bluz71 commented Aug 19, 2022

There appears to be an issue if folks, such as myself, don't use devicons / nerd-font.

Image before #2099 (this is correct):

before

Image after #2099:

after

Look at the first tmux.conf selection line, notice the red t in the after image. If I was to guess, this looks to be an off-by-one error for folks who are not using devicons (but that's just a guess, and maybe incorrect).

Anyway, it would be good to fix this item as part of this issue. I am willing to test things out as necessary.

Cheers.

@fdschmidt93
Copy link
Member

For simplicity, I'll revert the last commit as fixing these issues is quite a lot more tedious than I'd hope for (I'm quite busy until the week after next week) and it worked just fine previously.

Just as a reference for anyone coming here, https://github.com/nvim-telescope/telescope.nvim/commits/0.1.x is the more stable branch to go to that also receives fixes post 0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants