Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_zoom revisions and other final cleanups #223

Closed
63 of 69 tasks
nvkelso opened this issue Sep 28, 2017 · 6 comments
Closed
63 of 69 tasks

min_zoom revisions and other final cleanups #223

nvkelso opened this issue Sep 28, 2017 · 6 comments
Milestone

Comments

@nvkelso
Copy link
Owner

nvkelso commented Sep 28, 2017

In performing QA for #202 a few issues have come up...

  • countries should have a min_zoom (almost always 0) and a min_label
    • don't leave the 50m or 110m tiny country points behind
    • also disputed areas, take from their boundary line min_zoom – else Kashmir is a mire 😢
      • May need to x-fade disputed areas / labels into zoom 8 over OSM in implementations like Tilezen?
  • states should have a min_zoom (almost always 0) and a min_label
  • adjust min_zoom values
    • 10m, 50m, 110m coastline min_zoom needs to match land scale rank min_zoom
    • 110m physical label areas should only have continents (not others)
    • 50m disputed boundary polygons Kiril from 1.7 to 3
    • 50m physical label areas still too dense
      • downgrade most in Asia
    • 10m marine polygons are suspicious at zoom 3
    • 10m countries GUAM to zoom 3
    • 10m countries ST PIER AND MIQ. to zoom 5
    • 10m admin1 lines, polygons
      • JAPAN lines to min_zoom 7 (was 3) ... the polygons should go to 7 or 8? other changes like this already made?
    • 10m for 110 populated places min_label
      • New York to 1.7
      • Rio to 1.7
      • Cape Town to 1.7
      • Paris to 1.7
      • London to 1.7
      • Moscow to 1.7
      • Beijing to 1.7
      • Tokyo to 1.7
      • Sydney to 1.7
    • 10m populated places this is rank_max and rank_min already
      • add pop_rank, see WOF
    • 10m countries
      • add pop_rank, see WOF
    • country min_label
      • Japan to 1.7????
      • Bolivia to 3.0
      • Ven to 3.0
      • Angola to 3.0
      • Namibia to 3.0
      • Mali to 3.0
      • Algeria to 3.0
      • Poland to 3.0
      • Ukraine to 3.0
      • Norway, Finland, Sweden to 3.0
      • Iraq to 3.0
      • Iran to 3.0
      • Saudi Arabia to 3.0
      • Afghanistan to 3.0
      • Pakistan to 3.0
      • Kazikstan to 3.0
      • Mongolia to 3.0
      • South Korea to 3.0
      • Philipeans to 3.0
      • PNG to 3.0
  • random stuff
    • 10m roads are used on the zoom 2, 3, and 4!?
      • this is correct, but maybe we should have a 50m roads layer then? Would need x-fade instructions for an implementation like Tilezen
    • 10m land scale rank has an extra scalerank_ field?
    • 10m admin 1
      • some should still show up in the 50m range?! at least zoom 4, maybe zoom 3?
      • This is really 4.6 in the 10m file already
      • limit min_label to 5 instead of 4.6 though?
    • physical areas need to know if they dup an admin name (like Cuba)
    • canada (possibly other) adm1 max_label needs to go from 5 to 7
    • the geography areas & etc should be min_label and max_label (not zoom)?!
    • should geographic lines get a max_zoom?
      - [ ] showing inclusive to zoom 7 is fine
    • non-USA state labels dont' show up? see Europe
    • (minor) islands of Norway missing
    • 10m rivers
      • too many (parenthetical) names still, especially in India/China
      • add min_label attr
    • USA map unit needs the full consistent name "United States of America"
@nvkelso
Copy link
Owner Author

nvkelso commented Sep 30, 2017

For population_rank (or pop_rank because SHP 10 char column name limits):

if population >= 1000000000: 
	population_rank = 18
elif population >= 100000000: 
	population_rank = 17
elif population >= 50000000: 
	population_rank = 16
elif population >= 20000000: 
	population_rank = 15
elif population >= 10000000: 
	population_rank = 14
elif population>= 5000000:
	population_rank = 13
elif population>= 1000000:
	population_rank = 12
elif population >= 500000:
	population_rank = 11
elif population >= 200000:
	population_rank = 10
elif population >= 100000:
	population_rank = 9
elif population >= 50000:
	population_rank = 8
elif population >= 20000:
	population_rank = 7
elif population >= 10000:
	population_rank = 6
elif population >= 5000:
	population_rank = 5
elif population >= 2000:
	population_rank = 4
elif population >= 1000:
	population_rank = 3
elif population >= 200:
	population_rank = 2
elif population > 0:
	population_rank = 1

@nvkelso
Copy link
Owner Author

nvkelso commented Oct 1, 2017

physical areas need to know if they dup an admin name (like Cuba)

This should be resolved by collision rank instead in the style.

UPDATE: This still fails Greenland, but mostly works looking at basic QGIS config.

@nvkelso
Copy link
Owner Author

nvkelso commented Oct 3, 2017

so disputed areas, take from their boundary line min_zoom – else Kashmir is a mire

Is mostly working but Kashmire needs a little more work

@nvkelso
Copy link
Owner Author

nvkelso commented Oct 5, 2017

10m, 50m, 110m coastline min_zoom needs to match land scale rank min_zoom

I think this is the last big thing left besides zipping everything up and posting v4 of Natural Earth to the public site?

@nvkelso
Copy link
Owner Author

nvkelso commented Oct 6, 2017

Coastlines were 99.9% good, couple dozen edits in 63b9b08.

@nvkelso
Copy link
Owner Author

nvkelso commented Oct 6, 2017

Let's call this done :)

@nvkelso nvkelso closed this as completed Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant