Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Msg.locale with on-prem WhatsApp channels too #560

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

rowanseymour
Copy link
Member

Replicates #559 for non-cloud WA channels

@rowanseymour rowanseymour requested a review from norkans7 January 30, 2023 19:01
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #560 (3e6277b) into main (2083ac5) will decrease coverage by 0.05%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   74.63%   74.58%   -0.05%     
==========================================
  Files         100      100              
  Lines       12787    12786       -1     
==========================================
- Hits         9543     9536       -7     
- Misses       2563     2567       +4     
- Partials      681      683       +2     
Impacted Files Coverage Δ
handlers/facebookapp/facebookapp.go 82.89% <ø> (-0.02%) ⬇️
handlers/whatsapp/whatsapp.go 78.11% <87.50%> (-0.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit 78e4f9c into main Jan 30, 2023
@rowanseymour rowanseymour deleted the msg_locale_for_old_whatsapp branch January 30, 2023 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants