-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for localizing Menu header on facebook list messages #561
Conversation
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 74.58% 74.58%
=======================================
Files 100 100
Lines 12786 12786
=======================================
Hits 9536 9536
Misses 2567 2567
Partials 683 683
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
"uzb": "uz", // Uzbek | ||
"vie": "vi", // Vietnamese | ||
"zul": "zu", // Zulu | ||
var supportedLanguages = map[courier.Locale]languageInfo{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robi9 if you know more translations please make a PR!
@@ -1565,96 +1565,101 @@ type MsgTemplating struct { | |||
Variables []string `json:"variables"` | |||
} | |||
|
|||
func getSupportedLanguage(lc courier.Locale) string { | |||
func getSupportedLanguage(lc courier.Locale) languageInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably best to move this method somewhere else and reuse the same for the old whatsapp handler too that as well need similar changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
courier/handlers/whatsapp/whatsapp.go
Line 1161 in a0fd653
func getSupportedLanguage(lc courier.Locale) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chatted with @ericnewcomer and the plan is to keep the legacy Whatsapp handler working but not add any new features to it, and this would be a new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
Adds #541