Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for localizing Menu header on facebook list messages #561

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

rowanseymour
Copy link
Member

Adds #541

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #561 (a0fd653) into main (ee880be) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         100      100           
  Lines       12786    12786           
=======================================
  Hits         9536     9536           
  Misses       2567     2567           
  Partials      683      683           
Impacted Files Coverage Δ
handlers/facebookapp/facebookapp.go 82.89% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

"uzb": "uz", // Uzbek
"vie": "vi", // Vietnamese
"zul": "zu", // Zulu
var supportedLanguages = map[courier.Locale]languageInfo{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robi9 if you know more translations please make a PR!

@rowanseymour rowanseymour requested a review from norkans7 January 30, 2023 21:08
@@ -1565,96 +1565,101 @@ type MsgTemplating struct {
Variables []string `json:"variables"`
}

func getSupportedLanguage(lc courier.Locale) string {
func getSupportedLanguage(lc courier.Locale) languageInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to move this method somewhere else and reuse the same for the old whatsapp handler too that as well need similar changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func getSupportedLanguage(lc courier.Locale) string {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted with @ericnewcomer and the plan is to keep the legacy Whatsapp handler working but not add any new features to it, and this would be a new feature

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@rowanseymour rowanseymour requested a review from norkans7 January 31, 2023 16:58
@rowanseymour rowanseymour merged commit 4d7512b into main Jan 31, 2023
@rowanseymour rowanseymour deleted the menu_localization branch January 31, 2023 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants