Add support for localizing Menu header on facebook list messages #561
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1123,7 +1123,7 @@ func (h *handler) sendCloudAPIWhatsappMsg(ctx context.Context, msg courier.Msg, | |
| msgParts = handlers.SplitMsgByChannel(msg.Channel(), msg.Text(), maxMsgLength) | ||
| } | ||
| qrs := msg.QuickReplies() | ||
| lang := getSupportedLanguage(msg.Locale()) | ||
|
|
||
| var payloadAudio wacMTPayload | ||
|
|
||
|
|
@@ -1140,7 +1140,7 @@ func (h *handler) sendCloudAPIWhatsappMsg(ctx context.Context, msg courier.Msg, | |
|
|
||
| payload.Type = "template" | ||
|
|
||
| template := wacTemplate{Name: templating.Template.Name, Language: &wacLanguage{Policy: "deterministic", Code: lang.code}} | ||
| payload.Template = &template | ||
|
|
||
| component := &wacComponent{Type: "body"} | ||
|
|
@@ -1202,7 +1202,7 @@ func (h *handler) sendCloudAPIWhatsappMsg(ctx context.Context, msg courier.Msg, | |
| Button string "json:\"button,omitempty\"" | ||
| Sections []wacMTSection "json:\"sections,omitempty\"" | ||
| Buttons []wacMTButton "json:\"buttons,omitempty\"" | ||
| }{Button: lang.menu, Sections: []wacMTSection{ | ||
| section, | ||
| }} | ||
|
|
||
|
|
@@ -1350,7 +1350,7 @@ func (h *handler) sendCloudAPIWhatsappMsg(ctx context.Context, msg courier.Msg, | |
| Button string "json:\"button,omitempty\"" | ||
| Sections []wacMTSection "json:\"sections,omitempty\"" | ||
| Buttons []wacMTButton "json:\"buttons,omitempty\"" | ||
| }{Button: lang.menu, Sections: []wacMTSection{ | ||
| section, | ||
| }} | ||
|
|
||
|
|
@@ -1565,96 +1565,101 @@ type MsgTemplating struct { | |
| Variables []string `json:"variables"` | ||
| } | ||
|
|
||
| func getSupportedLanguage(lc courier.Locale) languageInfo { | ||
| // look for exact match | ||
| if lang := supportedLanguages[lc]; lang.code != "" { | ||
| return lang | ||
| } | ||
|
|
||
| // if we have a country, strip that off and look again for a match | ||
| l, c := lc.ToParts() | ||
| if c != "" { | ||
| if lang := supportedLanguages[courier.Locale(l)]; lang.code != "" { | ||
| return lang | ||
| } | ||
| } | ||
| return supportedLanguages["eng"] // fallback to English | ||
| } | ||
|
|
||
| type languageInfo struct { | ||
| code string | ||
| menu string // translation of "Menu" | ||
| } | ||
|
|
||
| // Mapping from engine locales to supported languages. Note that these are not all valid BCP47 codes, e.g. fil | ||
| // see https://developers.facebook.com/docs/whatsapp/api/messages/message-templates/ | ||
| var supportedLanguages = map[courier.Locale]languageInfo{ | ||
|
There was a problem hiding this comment. @Robi9 if you know more translations please make a PR! |
||
| "afr": {code: "af", menu: "Kieslys"}, // Afrikaans | ||
| "sqi": {code: "sq", menu: "Menu"}, // Albanian | ||
| "ara": {code: "ar", menu: "قائمة"}, // Arabic | ||
| "aze": {code: "az", menu: "Menu"}, // Azerbaijani | ||
| "ben": {code: "bn", menu: "Menu"}, // Bengali | ||
| "bul": {code: "bg", menu: "Menu"}, // Bulgarian | ||
| "cat": {code: "ca", menu: "Menu"}, // Catalan | ||
| "zho": {code: "zh_CN", menu: "菜单"}, // Chinese | ||
| "zho-CN": {code: "zh_CN", menu: "菜单"}, // Chinese (CHN) | ||
| "zho-HK": {code: "zh_HK", menu: "菜单"}, // Chinese (HKG) | ||
| "zho-TW": {code: "zh_TW", menu: "菜单"}, // Chinese (TAI) | ||
| "hrv": {code: "hr", menu: "Menu"}, // Croatian | ||
| "ces": {code: "cs", menu: "Menu"}, // Czech | ||
| "dah": {code: "da", menu: "Menu"}, // Danish | ||
| "nld": {code: "nl", menu: "Menu"}, // Dutch | ||
| "eng": {code: "en", menu: "Menu"}, // English | ||
| "eng-GB": {code: "en_GB", menu: "Menu"}, // English (UK) | ||
| "eng-US": {code: "en_US", menu: "Menu"}, // English (US) | ||
| "est": {code: "et", menu: "Menu"}, // Estonian | ||
| "fil": {code: "fil", menu: "Menu"}, // Filipino | ||
| "fin": {code: "fi", menu: "Menu"}, // Finnish | ||
| "fra": {code: "fr", menu: "Menu"}, // French | ||
| "kat": {code: "ka", menu: "Menu"}, // Georgian | ||
| "deu": {code: "de", menu: "Menü"}, // German | ||
| "ell": {code: "el", menu: "Menu"}, // Greek | ||
| "guj": {code: "gu", menu: "Menu"}, // Gujarati | ||
| "hau": {code: "ha", menu: "Menu"}, // Hausa | ||
| "enb": {code: "he", menu: "תפריט"}, // Hebrew | ||
| "hin": {code: "hi", menu: "Menu"}, // Hindi | ||
| "hun": {code: "hu", menu: "Menu"}, // Hungarian | ||
| "ind": {code: "id", menu: "Menu"}, // Indonesian | ||
| "gle": {code: "ga", menu: "Roghchlár"}, // Irish | ||
| "ita": {code: "it", menu: "Menu"}, // Italian | ||
| "jpn": {code: "ja", menu: "Menu"}, // Japanese | ||
| "kan": {code: "kn", menu: "Menu"}, // Kannada | ||
| "kaz": {code: "kk", menu: "Menu"}, // Kazakh | ||
| "kin": {code: "rw_RW", menu: "Menu"}, // Kinyarwanda | ||
| "kor": {code: "ko", menu: "Menu"}, // Korean | ||
| "kir": {code: "ky_KG", menu: "Menu"}, // Kyrgyzstan | ||
| "lao": {code: "lo", menu: "Menu"}, // Lao | ||
| "lav": {code: "lv", menu: "Menu"}, // Latvian | ||
| "lit": {code: "lt", menu: "Menu"}, // Lithuanian | ||
| "mal": {code: "ml", menu: "Menu"}, // Malayalam | ||
| "mkd": {code: "mk", menu: "Menu"}, // Macedonian | ||
| "msa": {code: "ms", menu: "Menu"}, // Malay | ||
| "mar": {code: "mr", menu: "Menu"}, // Marathi | ||
| "nob": {code: "nb", menu: "Menu"}, // Norwegian | ||
| "fas": {code: "fa", menu: "Menu"}, // Persian | ||
| "pol": {code: "pl", menu: "Menu"}, // Polish | ||
| "por": {code: "pt_PT", menu: "Menu"}, // Portuguese | ||
| "por-BR": {code: "pt_BR", menu: "Menu"}, // Portuguese (BR) | ||
| "por-PT": {code: "pt_PT", menu: "Menu"}, // Portuguese (POR) | ||
| "pan": {code: "pa", menu: "Menu"}, // Punjabi | ||
| "ron": {code: "ro", menu: "Menu"}, // Romanian | ||
| "rus": {code: "ru", menu: "Menu"}, // Russian | ||
| "srp": {code: "sr", menu: "Menu"}, // Serbian | ||
| "slk": {code: "sk", menu: "Menu"}, // Slovak | ||
| "slv": {code: "sl", menu: "Menu"}, // Slovenian | ||
| "spa": {code: "es", menu: "Menú"}, // Spanish | ||
| "spa-AR": {code: "es_AR", menu: "Menú"}, // Spanish (ARG) | ||
| "spa-ES": {code: "es_ES", menu: "Menú"}, // Spanish (SPA) | ||
| "spa-MX": {code: "es_MX", menu: "Menú"}, // Spanish (MEX) | ||
| "swa": {code: "sw", menu: "Menyu"}, // Swahili | ||
| "swe": {code: "sv", menu: "Menu"}, // Swedish | ||
| "tam": {code: "ta", menu: "Menu"}, // Tamil | ||
| "tel": {code: "te", menu: "Menu"}, // Telugu | ||
| "tha": {code: "th", menu: "Menu"}, // Thai | ||
| "tur": {code: "tr", menu: "Menu"}, // Turkish | ||
| "ukr": {code: "uk", menu: "Menu"}, // Ukrainian | ||
| "urd": {code: "ur", menu: "Menu"}, // Urdu | ||
| "uzb": {code: "uz", menu: "Menu"}, // Uzbek | ||
| "vie": {code: "vi", menu: "Menu"}, // Vietnamese | ||
| "zul": {code: "zu", menu: "Menu"}, // Zulu | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably best to move this method somewhere else and reuse the same for the old whatsapp handler too that as well need similar changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
courier/handlers/whatsapp/whatsapp.go
Line 1161 in a0fd653
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chatted with @ericnewcomer and the plan is to keep the legacy Whatsapp handler working but not add any new features to it, and this would be a new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay