Fix setting of log type of channel logs and add additional types #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jul 26, 2023
| @@ -23,9 +23,11 @@ const ( | |||
| ChannelLogTypeMsgStatus ChannelLogType = "msg_status" | |||
| ChannelLogTypeMsgReceive ChannelLogType = "msg_receive" | |||
| ChannelLogTypeEventReceive ChannelLogType = "event_receive" | |||
| ChannelLogTypeMultiReceive ChannelLogType = "multi_receive" | |||
There was a problem hiding this comment.
when a payload can contain a mixture of things
rowanseymour
force-pushed
the
better_log_types
branch
from
d8e0ff1 to
92fa928
Compare
Codecov Report
@@ Coverage Diff @@
## main #605 +/- ##
==========================================
+ Coverage 74.38% 74.46% +0.08%
==========================================
Files 98 98
Lines 13153 13188 +35
==========================================
+ Hits 9784 9821 +37
+ Misses 2670 2668 -2
Partials 699 699
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rowanseymour
commented
Jul 26, 2023
| @@ -35,7 +35,7 @@ func init() { | |||
| // Initialize is called by the engine once everything is loaded | |||
| func (h *handler) Initialize(s courier.Server) error { | |||
| h.SetServer(s) | |||
| s.AddHandlerRoute(h, http.MethodPost, "receive", h.receiveMessage) | |||
| s.AddHandlerRoute(h, http.MethodPost, "receive", courier.ChannelLogTypeUnknown, h.receiveMessage) | |||
There was a problem hiding this comment.
for routes where we can't know until we parse the payload.. it's set manually with SetType in the method
rowanseymour
commented
Jul 26, 2023
| // receiveEvent is our HTTP handler function for incoming messages and status updates | ||
| func (h *handler) receiveEvent(ctx context.Context, channel courier.Channel, w http.ResponseWriter, r *http.Request, payload *moPayload, clog *courier.ChannelLog) ([]courier.Event, error) { | ||
| // receiveEvents is our HTTP handler function for incoming messages and status updates | ||
| func (h *handler) receiveEvents(ctx context.Context, channel courier.Channel, w http.ResponseWriter, r *http.Request, payload *moPayload, clog *courier.ChannelLog) ([]courier.Event, error) { |
There was a problem hiding this comment.
renamed for clarity
norkans7
reviewed
Jul 26, 2023
handlers/mblox/mblox.go
Outdated
| @@ -62,6 +62,8 @@ var statusMapping = map[string]courier.MsgStatusValue{ | |||
| // receiveEvent is our HTTP handler function for incoming messages | |||
| func (h *handler) receiveEvent(ctx context.Context, channel courier.Channel, w http.ResponseWriter, r *http.Request, payload *eventPayload, clog *courier.ChannelLog) ([]courier.Event, error) { | |||
| if payload.Type == "recipient_delivery_report_sms" { | |||
| clog.SetType(courier.ChannelLogTypeEventReceive) | |||
There was a problem hiding this comment.
This should be be courier.ChannelLogTypeMsgStatus?
rowanseymour
force-pushed
the
better_log_types
branch
from
92fa928 to
c8e241b
Compare
norkans7
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.