Remove AnonymousUser #5884
Remove AnonymousUser #5884
Conversation
rowanseymour
force-pushed
the
remove_anon_user
branch
from
379a4a3 to
e3096f5
Compare
rowanseymour
force-pushed
the
remove_anon_user
branch
from
e3096f5 to
ee6ebab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5884 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 488 488
Lines 25242 25235 -7
=========================================
- Hits 25242 25235 -7 ☔ View full report in Codecov by Sentry. |
| @@ -603,7 +601,7 @@ def contact_resolve(org, phone: str) -> tuple: | |||
| if contact_urn: | |||
| contact = contact_urn.contact | |||
| else: | |||
| contact = create_contact_locally(org, user, name="", language="", urns=[urn], fields={}, group_uuids=[]) | |||
| contact = create_contact_locally(org, None, name="", language="", urns=[urn], fields={}, group_uuids=[]) | |||
There was a problem hiding this comment.
We allow created_by to be null for contacts! why not use system user instead here as well?
There was a problem hiding this comment.
I don't want mailroom and courier to have to find the system user.. null user feels more right anyway.
There was a problem hiding this comment.
Although... I'm having second thoughts about this. Courier and Mailroom were just using userid=1 which isn't even the same thing on our deployments. Maybe it would be nicer from a auditing point of view if all engine modifications to a contact used system.. instead of null meaning that.. modified_by=null makes it look like it was never modified.
No description provided.