Allow FlowRun.session to be null
#5912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
remove_run_session_pt1
branch
from
9b2ce3f to
7d6d8bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5912 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 505 506 +1
Lines 25287 25274 -13
=========================================
- Hits 25287 25274 -13 ☔ View full report in Codecov by Sentry. |
rowanseymour
commented
Feb 26, 2025
| @@ -640,7 +640,7 @@ def test_history(self): | |||
|
|
|||
| # fetch our contact history | |||
| self.login(self.admin) | |||
| with self.assertNumQueries(23): | |||
| with self.assertNumQueries(22): | |||
There was a problem hiding this comment.
this appears to be a missing prefetch on run.session
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.