Add flow run path_nodes and path_times fields #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 63.08% 61.11% -1.97%
==========================================
Files 7 7
Lines 997 1304 +307
==========================================
+ Hits 629 797 +168
- Misses 263 402 +139
Partials 105 105 ☔ View full report in Codecov by Sentry. |
norkans7
changed the title
norkans7
commented
Dec 4, 2024
testdb.sql
Outdated
| (2, '7d68469c-0494-498a-bdf3-bac68321fd6d', 2, TRUE, 6, 1, | ||
| '{"agree": {"category": "Strongly agree", "node_uuid": "a0434c54-3e26-4eb0-bafc-46cdeaf435ac", "name": "Do you agree?", "value": "A", "created_on": "2017-05-03T12:25:21.714339+00:00", "input": "A"}}', | ||
| '[{"uuid": "c3d0b417-db75-417c-8050-33776ec8f620", "node_uuid": "10896d63-8df7-4022-88dd-a9d93edf355b", "arrived_on": "2017-08-12T15:07:24.049815+02:00", "exit_uuid": "2f890507-2ad2-4bd1-92fc-0ca031155fca"}]', | ||
| '2017-08-12 21:11:59.890662+02:00','2017-08-12 21:11:59.890662+02:00','2017-08-12 21:11:59.890662+02:00', 'C', NULL), | ||
| '{"d1a55403-83a3-42f1-b24c-6446bb18e6a6"}', '{"2017-08-12T15:07:25.049815+02:00"}', '2017-08-12 21:11:59.890662+02:00','2017-08-12 21:11:59.890662+02:00','2017-08-12 21:11:59.890662+02:00', 'C', NULL), |
There was a problem hiding this comment.
I intentionally set the path_nodes and path times to not match the values in path for to be sure with the tests
OLD node "10896d63-8df7-4022-88dd-a9d93edf355b"
NEW node "d1a55403-83a3-42f1-b24c-6446bb18e6a6"
There was a problem hiding this comment.
that's fine - but let's tweak this to have 2 items in the path to check that the arrays are merged correctly
norkans7
commented
Dec 4, 2024
| @@ -24,36 +24,47 @@ const ( | |||
| const sqlLookupRuns = ` | |||
| SELECT rec.uuid, rec.exited_on, row_to_json(rec) | |||
| FROM ( | |||
| SELECT | |||
There was a problem hiding this comment.
actual change f0cb122
norkans7
force-pushed
the
update-fields
branch
from
a0153f5 to
629c2ef
Compare
norkans7
commented
Dec 5, 2024
| (5, 'abed67d2-06b8-4749-8bb9-ecda037b673b', 3, TRUE, 7, 2, '{}', '[]', NULL, NULL, '2017-10-10 21:11:59.890663+02:00','2017-10-10 21:11:59.890662+02:00','2017-10-10 21:11:59.890662+02:00', 'C', NULL), | ||
| (6, '6262eefe-a6e9-4201-9b76-a7f25e3b7f29', 3, TRUE, 7, 2, '{}', '[]', NULL, NULL, '2017-12-12 21:11:59.890662+02:00','2017-12-12 21:11:59.890662+02:00','2017-12-12 21:11:59.890662+02:00', 'C', NULL), | ||
| (7, '6c0d7db9-076b-4edc-ab4b-38576ae394fc', 2, TRUE, 7, 2, '{}', '[]', NULL, NULL, '2017-08-13 13:11:59.890662+02:00','2017-08-14 16:11:59.890662+02:00', NULL, 'W', NULL), | ||
| (8, '0c54f7b9-875b-4385-ae85-fb9e84f4b3d6', 2, TRUE, 6, 1, |
There was a problem hiding this comment.
Add a new run with path nodes and path times
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add the fields to the test DB
Use the path_nodes and path_times when set