update table references, use wrapf for errors #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicpottier
commented
Jul 25, 2019
| @@ -336,13 +332,6 @@ func BuildRollupArchive(ctx context.Context, db *sqlx.DB, conf *Config, s3Client | |||
|
|
|||
| start := time.Now() | |||
|
|
|||
| log := logrus.WithFields(logrus.Fields{ | |||
There was a problem hiding this comment.
logging is the responsibility of the parent that doesn't pass the error up.
nicpottier
commented
Jul 25, 2019
| var exitedOn *time.Time | ||
| for rows.Next() { | ||
| if archive.ArchiveType == MessageType { |
There was a problem hiding this comment.
MessageType block was never entered, when we added broadcast deleting we changed to our own method.
nicpottier
commented
Jul 25, 2019
|
|
||
| // then add in daily archives taking into account the monthly that have been built |
nicpottier
commented
Jul 25, 2019
| const deleteRecentRuns = ` | ||
| DELETE FROM flows_flowpathrecentrun | ||
| WHERE run_id IN(?) | ||
| ` | ||
|
|
||
| const deleteActionLogs = ` | ||
| DELETE FROM flows_actionlog | ||
| WHERE run_id IN(?) |
There was a problem hiding this comment.
Table still exists but shouldn't be any runs in it.
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
+ Coverage 68.08% 69.8% +1.72%
=========================================
Files 3 3
Lines 943 891 -52
=========================================
- Hits 642 622 -20
+ Misses 181 156 -25
+ Partials 120 113 -7
Continue to review full report at Codecov.
|
rowanseymour
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broke deleting of runs when we removed
run_idfrom webhook_event and webhook_result.