Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back timestamp precondition by wrapping global slot #579

Closed
mitschabaude opened this issue Nov 18, 2022 · 1 comment · Fixed by #755
Closed

Add back timestamp precondition by wrapping global slot #579

mitschabaude opened this issue Nov 18, 2022 · 1 comment · Fixed by #755
Assignees
@mitschabaude
Labels
eng-priority Issues that seem high priority to one engineer pending-release Issues that specify work to be done for a new release to-discuss Issues to be discussed further

Comments

@mitschabaude
Copy link
Collaborator

mitschabaude commented Nov 18, 2022 •
edited
Loading

This PR: MinaProtocol/mina#12234
removes the timestamp precondition. However, that precondition is a very user-friendly way to access the current time in a smart contract. We should bring it back on the berkeley branch by adding a wrapper around globalSlotSinceGenesis
@mitschabaude mitschabaude added to-discuss Issues to be discussed further pending-release Issues that specify work to be done for a new release labels Jan 5, 2023
@mitschabaude mitschabaude added the eng-priority Issues that seem high priority to one engineer label Feb 6, 2023
@jasongitmail
Copy link
Contributor

needs mini RFC

@mitschabaude mitschabaude self-assigned this Feb 27, 2023
@mitschabaude mitschabaude mentioned this issue Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitschabaude mitschabaude

Labels
eng-priority Issues that seem high priority to one engineer pending-release Issues that specify work to be done for a new release to-discuss Issues to be discussed further
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back timestamp precondition o1-labs/o1js
2 participants
@mitschabaude @jasongitmail