Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework Group.scale to accept a non-shifted scalar and values of 0 and 1 #980

Closed
Trivo25 opened this issue Jun 12, 2023 · 0 comments · Fixed by #1530
Closed

rework Group.scale to accept a non-shifted scalar and values of 0 and 1 #980

Trivo25 opened this issue Jun 12, 2023 · 0 comments · Fixed by #1530
Assignees
@mitschabaude
Labels
v1 Prerequisite for o1js v1.0 zkDSL Issues to improve the core experience of writing circuits

Comments

@Trivo25
Copy link
Member

Trivo25 commented Jun 12, 2023

Currently, Group.scale only takes shifted scalar values -- it would be nice to add an implementation that works with non-shifted values. Additionally, scale does not accept 0 or 1 (g * 1 = g and g * 0 = zero) but throws an error instead.
@mitschabaude mitschabaude added the zkDSL Issues to improve the core experience of writing circuits label Dec 13, 2023
@mitschabaude mitschabaude mentioned this issue Apr 8, 2024
Merged
@mitschabaude mitschabaude self-assigned this Apr 9, 2024
@garwalsh garwalsh added the v1 Prerequisite for o1js v1.0 label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitschabaude mitschabaude

Labels
v1 Prerequisite for o1js v1.0 zkDSL Issues to improve the core experience of writing circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Efficient scalar mul and other Scalar improvements o1-labs/o1js
3 participants
@garwalsh @mitschabaude @Trivo25