Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain Other on ES 6 and 7 Broken #25

Closed
epugh opened this issue Nov 15, 2019 · 2 comments · Fixed by o19s/splainer-search#74
Closed

Explain Other on ES 6 and 7 Broken #25

epugh opened this issue Nov 15, 2019 · 2 comments · Fixed by o19s/splainer-search#74

Comments

@epugh
Copy link
Member

epugh commented Nov 15, 2019

Describe the bug
With ES 6 and 7, but not in ES 5, the explain Other function doesn't work.

To Reproduce
Steps to reproduce the behavior:

  1. Make a movie case. Search for Rambo.
  2. Click Explain Missing
  3. Search for title:rambo
  4. You will get results, but no explain in ES 6 and 7

Expected behavior
you should get explains!
@epugh
Copy link
Member Author

epugh commented Nov 15, 2019

From @worleydl:

While investigating quepid issues, there appears to be issues around the explDict in splainer.js when it fetches explains from the _explain handler. Changing the "explanation" property to be details got things working in 5/6 but caused 7 to not return any results

@worleydl worleydl mentioned this issue Jan 9, 2020
Merged
@epugh
Copy link
Member Author

epugh commented Jan 10, 2020

Ack, havn't updated Quepid yet!

@epugh epugh reopened this Jan 10, 2020
@epugh epugh closed this as completed in 1037f87 Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return explDict in consistent format o19s/splainer-search
1 participant
@epugh