Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gender optional #69

Open
hameno opened this issue Oct 12, 2020 · 3 comments
Open

Make gender optional #69

hameno opened this issue Oct 12, 2020 · 3 comments

Comments

@hameno
Copy link

hameno commented Oct 12, 2020

Description

We're implementing LDAP auth and we don't have genders saved in LDAP. Can we make the gender field optional or allow "other"?
(Also, not trying to start any discussions, but m/w is too limited nowadays anyway ;) )

Acceptance criteria:

Allow other ("o") for gender

Connected requirement IDs

Mockup

@hameno
Copy link
Author

hameno commented Oct 12, 2020

Also, I just noticed the profile has a "Time zone" field, can we set a default or provide it via external auth aswell?

@maximskripnik
Copy link
Contributor

Hey @hameno. Thanks for the feedback!

As far as I remember, genders are optional via external auth. From the readme

gender : string, optional {'f', 'm', 'female', 'male', 'man', 'woman'} - user's gender.

I see your point regarding the 'other' gender though. Some social networks that we used for external authentication only provide two genders, so I figured that it should be good enough for us as well.

Anyway, is optional gender enough for your use case? Or maybe you encountered some issue that in fact makes this field mandatory that I am not aware of. Please provide more details in this case

@hameno
Copy link
Author

hameno commented Oct 13, 2020

Haven't actually tried to ommit it, I will try it.
I looked at the code and thought it will throw an exception if its missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants