Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible - Make conversion host record creation idempotent #25

Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2019

When running the conversion host enablement playbook more than once, it creates additional records for the conversion host in ManageIQ/CloudForms. This breaks the migration solution. This PR fixes it by deleting any existing conversion host matching the currently enabled host or VM.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1668423

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Added support for network mappings #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@ghost
Copy link
Author

ghost commented Feb 6, 2019

@nyoxi
Copy link
Member

nyoxi commented Feb 6, 2019

yamllint errors:

/home/travis/build/oVirt/ovirt-ansible-v2v-conversion-host/ansible/oVirt.v2v-conversion-host/tasks/install-manageiq-conversion-host.yml
  24:1      error    trailing spaces  (trailing-spaces)
  29:1      error    trailing spaces  (trailing-spaces)
  34:1      error    trailing spaces  (trailing-spaces)
  39:1      error    trailing spaces  (trailing-spaces)
  44:1      error    trailing spaces  (trailing-spaces)
  56:1      error    trailing spaces  (trailing-spaces)

@ghost ghost requested a review from nyoxi February 7, 2019 07:16
register: manageiq_conversion_hosts_json

- block:
- name: Isolate the relevant conversion hos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

@nyoxi
Copy link
Member

nyoxi commented Feb 8, 2019

ci test please

1 similar comment
@nyoxi
Copy link
Member

nyoxi commented Feb 11, 2019

ci test please

@nyoxi nyoxi merged commit ed28ab3 into oVirt:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants