Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check to allow checking SSH transport method #50

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2019

Role check action would fail when checking for SSH transport, because VVDK tasks would be called and fail. This PR calls the task file based on v2v_transport_method and adds an empty file for SSH transport task.

@ghost ghost requested a review from nyoxi April 2, 2019 12:02
Copy link
Member

@nyoxi nyoxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyoxi
Copy link
Member

nyoxi commented Apr 2, 2019

The Travis test failure is unrelated. Merging

@nyoxi nyoxi merged commit 9380790 into oVirt:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants