From 1af36057ad7d0879eeca20e57eaf245ec456856d Mon Sep 17 00:00:00 2001
From: Yangyang Gao <gayangya@microsoft.com>
Date: Mon, 7 Aug 2023 23:04:31 +0800
Subject: [PATCH] support min max aggregation with varbinary type

---
 velox/functions/prestosql/aggregates/MinMaxAggregates.cpp | 1 +
 velox/functions/prestosql/aggregates/tests/MinMaxTest.cpp | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp b/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp
index bc2102afb6e0..8e39392a67db 100644
--- a/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp
+++ b/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp
@@ -508,6 +508,7 @@ exec::AggregateRegistrationResult registerMinMax(const std::string& name) {
           case TypeKind::HUGEINT:
             return std::make_unique<TNumeric<int128_t>>(resultType);
           case TypeKind::VARCHAR:
+          case TypeKind::VARBINARY:
           case TypeKind::ARRAY:
           case TypeKind::MAP:
           case TypeKind::ROW:
diff --git a/velox/functions/prestosql/aggregates/tests/MinMaxTest.cpp b/velox/functions/prestosql/aggregates/tests/MinMaxTest.cpp
index df281a1dc383..5b06ca01704d 100644
--- a/velox/functions/prestosql/aggregates/tests/MinMaxTest.cpp
+++ b/velox/functions/prestosql/aggregates/tests/MinMaxTest.cpp
@@ -119,6 +119,10 @@ TEST_F(MinMaxTest, maxVarchar) {
   doTest(max, VARCHAR());
 }
 
+TEST_F(MinMaxTest, maxVarbinary) {
+  doTest(max, VARBINARY());
+}
+
 TEST_F(MinMaxTest, maxBoolean) {
   doTest(max, BOOLEAN());
 }
@@ -159,6 +163,10 @@ TEST_F(MinMaxTest, minVarchar) {
   doTest(min, VARCHAR());
 }
 
+TEST_F(MinMaxTest, minVarbinary) {
+  doTest(min, VARBINARY());
+}
+
 TEST_F(MinMaxTest, minBoolean) {
   doTest(min, BOOLEAN());
 }