Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutually exclusive features #134

Closed
thvdveld opened this issue Sep 28, 2022 · 4 comments
Closed

Mutually exclusive features #134

thvdveld opened this issue Sep 28, 2022 · 4 comments

Comments

@thvdveld
Copy link

Is there a reason why the all-features flag is passed? In some rare cases, features are mutually exclusive (for example in smoltcp) and therefore it's unable to use cargo-semver-check.

https://github.com/obi1kenobi/cargo-semver-check/blob/423444100fe09adde0d621a730fec01681fc1387/src/dump.rs#L79

@epage
Copy link
Collaborator

epage commented Sep 28, 2022

Reasons

  • We have not designed the configuration around this
  • One factor for designing config is that I'm hoping we can find a way to track conditional compilation and find breaking changes via feature changes. Knowing what direction we can go on this will have on impact on the design for configuring features.
  • Everything is generally a safe default for capturing the whole API
  • Mutually exclusive features are themselves not an officially supported use case within cargo, see Mutually exclusive features rust-lang/cargo#2980

@thvdveld
Copy link
Author

Thank you for the explanation!

@obi1kenobi
Copy link
Owner

v0.21 was just released and allows specifying the exact set of features to use, both by feature group (e.g. only default features) as well as at the level of individual features.

If you're able to take a look, I'd love to know if it resolved the issue you were having.

@thvdveld
Copy link
Author

thvdveld commented Jun 9, 2023

Using --default-features seems to work as expected. Thank you for the notification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants