Reject names with null-bytes in NamedLock::create. #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible to produce a panic on Windows with the following:
(notice no
.unwrap()
is required)There is also inconsistent behavior between platforms. On Windows the name
"\0"
is treated equivalent to an empty string, but on Unix""
is just fine while"\0"
results inErr(Error::CreateFailed)
.The simplest fix I can think of is to reject null-bytes altogether, in addition to
\
and/
. I think this is technically a breaking change, but a minor one.