Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File watchers become detached after editing markdown #108

Closed
mbostock opened this issue Nov 7, 2023 · 1 comment · Fixed by #109
Closed

File watchers become detached after editing markdown #108

mbostock opened this issue Nov 7, 2023 · 1 comment · Fixed by #109
Assignees
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

mbostock commented Nov 7, 2023

As shown here:

Screen.Recording.2023-11-06.at.6.46.55.PM.mov

To reproduce:

  • Create a text file (e.g., test.txt)
  • Load the text file into a Markdown file
  • Notice that editing the file updates the preview as expected
  • However, if you edit the Markdown file, subsequent edits to the text file are ignored

The bug seems to happen when the file watchers for attachments are re-initialized on update.

@mbostock mbostock added the bug Something isn’t working label Nov 7, 2023
@mbostock
Copy link
Member Author

mbostock commented Nov 7, 2023

Seems like we forgot to call watchAll…

await attachmentWatcher.watchAll();

@mbostock mbostock self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant