Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch files when their inode changes? #231

Closed
Fil opened this issue Nov 23, 2023 · 1 comment · Fixed by #276
Closed

watch files when their inode changes? #231

Fil opened this issue Nov 23, 2023 · 1 comment · Fixed by #276
Assignees
Labels
bug Something isn’t working
Milestone

Comments

@Fil
Copy link
Contributor

Fil commented Nov 23, 2023

I was doing tests with zip files, adding contents with:

zip docs/archive.zip file.txt

The page that depends on this file updates once, then stops watching the file.

After tracking down this bug it appears that zip changes the inode of the file. I can do this instead, which doesn't change the inode (and allows the dev server to keep watching):

zip docs/archive.tmp.zip file.txt && cat docs/archive.tmp.zip > docs/archive.zip

It would be nice to watch file changes even when their inode changes.

@Fil Fil added the enhancement New feature or request label Nov 23, 2023
@Fil Fil mentioned this issue Nov 23, 2023
7 tasks
@mbostock mbostock added this to the Early access milestone Nov 23, 2023
@mbostock mbostock added bug Something isn’t working and removed enhancement New feature or request labels Nov 23, 2023
@mbostock
Copy link
Member

Feels like a bug to me. I’d guess most people won’t know why the watcher stopped working. 😅

@mbostock mbostock self-assigned this Nov 29, 2023
@mbostock mbostock mentioned this issue Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants