Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy test fails when running it with .only #368

Closed
cinxmo opened this issue Dec 11, 2023 · 3 comments
Closed

Deploy test fails when running it with .only #368

cinxmo opened this issue Dec 11, 2023 · 3 comments
Assignees
Labels
test Related to automated testing

Comments

@cinxmo
Copy link
Contributor

cinxmo commented Dec 11, 2023

In deploy-test.ts:

  • Mark "makes expected API calls for a new project" with it.only
  • Run yarn test
  • Notice the failure:
  1) deploy
       makes expected API calls for a new project:
     TypeError: fetch failed
      at Object.fetch (node:internal/deps/undici/undici:11372:11)
      at <anonymous> (src/javascript/imports.ts:355:22)
@cinxmo cinxmo added the bug Something isn’t working label Dec 11, 2023
@cinxmo cinxmo self-assigned this Dec 11, 2023
@mythmon
Copy link
Member

mythmon commented Dec 11, 2023

I think this is #351, right? Mike and I both have our takes at fixing it. #362 is probably where we should continue.

@cinxmo
Copy link
Contributor Author

cinxmo commented Dec 11, 2023

@mythmon ah yes it sounds like it. I will wait for that PR to merge and then close this ticket.

@mbostock mbostock added test Related to automated testing and removed bug Something isn’t working labels Dec 22, 2023
@cinxmo cinxmo added this to the General availability milestone Jan 16, 2024
@mythmon
Copy link
Member

mythmon commented Jan 17, 2024

I think this should be fixed now, with #552.

@cinxmo cinxmo closed this as completed Jan 19, 2024
@cinxmo cinxmo assigned mythmon and unassigned cinxmo Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to automated testing
Projects
None yet
Development

No branches or pull requests

3 participants