Create an optional whitelist parameter #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Aug 27, 2018
| @@ -160,6 +169,15 @@ module.exports = (options = {}) => { | |||
| continue; | |||
| } | |||
| let parsedLicense = licenseObjects(parseSPDX(dependency.license)); | |||
| if (whitelist) { | |||
| for (let license of flattenLicense(parsedLicense)) { | |||
| if (!whitelistSet.has(license)) { | |||
There was a problem hiding this comment.
Is this being conservative in the sense that every mentioned license has to be whitelisted? I suppose we could have a more complex logical evaluator that handles the “MIT or GPL” case? (Doesn’t seem necessary to do that, just want to understand the intent…)
There was a problem hiding this comment.
Yeah, the intent is for this to be very conservative - I think there could be a more complex evaluator, but MIT or GPL is sufficiently rare, and the cases where there are 'viral or non-viral' clauses might have extra conditions that we'd want to manually review.
mbostock
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a whitelist parameter to the credits transform.