Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks should work inside admonitions #563

Closed
1 task done
Aonnghus opened this issue Mar 15, 2022 · 7 comments
Closed
1 task done

Tasks should work inside admonitions #563

Aonnghus opened this issue Mar 15, 2022 · 7 comments
Labels
scope: parsing markdown See also 'scope: global filter' status: wontfix This will not be worked on type: enhancement New feature or request

Comments

@Aonnghus
Copy link

Aonnghus commented Mar 15, 2022

Expected Behavior

Using tasks nested inside Obsidian Admonition should display this:
image

Current Behavior

Tasks are not synced and the global filter is shown (even with the "Remove global filter from description" setting):

image

Steps to Reproduce

  1. Install Obsidian Admonition plugin and Tasks plugin
  2. Set global filter to "#task"
  3. Create a new note with the following code:
```ad-info
title: Todo
- [ ] #task First test task
- [x] #task Second test task
```

```tasks
```

Context (Environment)

  • Obsidian version: 0.13.33
  • Tasks version: 1.4.1
  • Obsidian Admonition version: 8.1.0
  • I have tried it with all other plugins disabled and the error still occurs
@schemar
Copy link
Collaborator

schemar commented Mar 18, 2022

Interesting. I will need to dig deeper and test this in combination with admonition. However, my assumption is that this is due to the fact how Obsidian handles list items.

The Tasks plugin iterates over all list items that Obsidian found in a file. If Obsidian doesn’t regard text inside code blocks as list items, Tasks won’t recognize them either.

My assumption is that I won’t be able to easily fix this.

@schemar schemar added type: enhancement New feature or request help wanted Extra attention is needed labels Mar 18, 2022
@schemar schemar changed the title Tasks doesn't work inside admonitions Tasks should work inside admonitions Mar 18, 2022
@claremacrae claremacrae added the scope: parsing markdown See also 'scope: global filter' label Jun 9, 2022
@claremacrae
Copy link
Collaborator

See also #656, which is the same but for native callouts.

@TheDonPaul
Copy link

I'm not sure I agree with the conclusion that:

The Tasks plugin iterates over all list items that Obsidian found in a file. If Obsidian doesn’t regard text inside code blocks as list items, Tasks won’t recognize them either.

I tried this out by adding a callout with a task inside. I can click the checkbox, and dataview can find the task, both in LIST and TASK view - for both a dataview and a dataviewjs query.

So, it seems as Obsidian recognises the tasks, and dataview can also find them...

@claremacrae
Copy link
Collaborator

Thank you.

@AnnaKornfeldSimpson
Copy link
Contributor

I found @TheDonPaul 's comment to be true for Obsidian's native callouts, but NOT for admonitions plugin ones which are in codeblocks. Dataview cannot find tasks in codeblocks, as of currently.

@AnnaKornfeldSimpson
Copy link
Contributor

I feel pretty strongly that plugins do not want to be parsing inside others' code-blocks. If you want Tasks to find your tasks, use Obsidian's native callouts instead of Admonitions code-blocks for those, bug fix for callouts incoming in #953 . If using callouts does not work for you, or you disagree about parsing code-blocks from other plugins and would like to request that feature, I recommend opening a Discussion.

@AnnaKornfeldSimpson AnnaKornfeldSimpson closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2022
@claremacrae claremacrae added status: wontfix This will not be worked on and removed help wanted Extra attention is needed labels Jul 30, 2022
@claremacrae
Copy link
Collaborator

claremacrae commented Jul 30, 2022

I do agree with closing this. Thanks Anna.

Trivial house-keeping: I've updated tags status: wontfix Is a bit strong, but it's what we've got.

Edit: on reflection, the tag is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: parsing markdown See also 'scope: global filter' status: wontfix This will not be worked on type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants