From 6a2a8993533f94a460b339e0a76463a35192f7d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= Date: Fri, 24 Jul 2020 21:51:55 +0100 Subject: [PATCH] Fix typo in `(cache-check-probablity)` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I was trying to use it as documented here, but there is a typo when used as a config file entry (the cmdline entry seems fine): https://dune.readthedocs.io/en/stable/caching.html#reproducibility-check We also bump the required version to 2.7, as the feature wasn't usable before this release. Signed-off-by: Edwin Török --- CHANGES.md | 3 +++ src/dune/config.ml | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 096a16d804ff..79918580378c 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -43,6 +43,9 @@ next individual executables when they're part of an `executables` stanza group (#3644, @rgrinberg) +- Fix typo in `cache-check-probablity` field in dune config files. This field + now requires 2.7 as it wasn't usable before this version. (#3652, @edwintorok) + 2.6.1 (02/07/2020) ------------------ diff --git a/src/dune/config.ml b/src/dune/config.ml index 895a7e21953d..7bb4daa2180d 100644 --- a/src/dune/config.ml +++ b/src/dune/config.ml @@ -263,8 +263,8 @@ let decode = (Dune_lang.Syntax.since Stanza.syntax (2, 0) >>> Caching.Transport.decode) ~default:default.cache_transport and+ cache_check_probability = - field "cache-check-probablity" - (Dune_lang.Syntax.since Stanza.syntax (2, 0) >>> Dune_lang.Decoder.float) + field "cache-check-probability" + (Dune_lang.Syntax.since Stanza.syntax (2, 7) >>> Dune_lang.Decoder.float) ~default:default.cache_check_probability and+ cache_duplication = field "cache-duplication"