Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional flexibility over raw git describe in Build_info.version #3856

Open
jberdine opened this issue Oct 6, 2020 · 2 comments
Open

Additional flexibility over raw git describe in Build_info.version #3856

jberdine opened this issue Oct 6, 2020 · 2 comments
Assignees

Comments

@jberdine
Copy link
Contributor

jberdine commented Oct 6, 2020

Desired Behavior

Some additional flexibility over raw git describe would be useful when populating Build_info.version. For example, it would be useful to be able to generate package version numbers containing ~ to indicate (unreleased) versions since the last tagged release (e.g. using 1.5~10-3497327 for a commit with hash 3497327 that is 10 commits ahead of the 1.5 tag). Since ~ can't be used in git tags, there isn't a clear way to do this. I guess that the high level point is that it would be good if the core versioning functionality in dune could exercise the functionality that is in opam. The issues with ~ is one (maybe the only?) instance of that I have run into where I couldn't use what opam could do easily from dune.

@rgrinberg
Copy link
Member

We discussed this in the meeting and decided that it would be a good convention to implement. However, it will only be enabled for projects where the dun lang is >= 2.8.

@ghost ghost modified the milestones: 2.8, 2.9 Nov 25, 2020
@ejgallego
Copy link
Collaborator

Hi folks, I am removing this from the 2.9 milestone as it seems to me a fix is not going to be ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants