Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with installing re2 on 4.06 #392

Closed
yminsky opened this issue Jan 5, 2018 · 3 comments
Closed

Problem with installing re2 on 4.06 #392

yminsky opened this issue Jan 5, 2018 · 3 comments

Comments

@yminsky
Copy link
Contributor

yminsky commented Jan 5, 2018

Apparently, this issue is due to a jbuilder bug: janestreet/re2#22

This seems like a better place to track it.
@yminsky yminsky mentioned this issue Jan 5, 2018
Closed
@rgrinberg
Copy link
Member

The issue seems to be caused by a 4.06.0 switch having arguments in the c_compiler option. @yminsky 's config:

c_compiler: cc -O2 -pipe
ocamlc_cflags: -O2 -fno-strict-aliasing -fwrapv
ocamlopt_cflags: -O2 -fno-strict-aliasing -fwrapv

While jbuilder assumes that c_compiler is just a binary and doesn't contain any flags.

@rgrinberg
Copy link
Member

This is fixed. @yminsky try this out again in the upcoming beta 17 (sorry for the delays...)

@yminsky
Copy link
Contributor Author

yminsky commented Jan 27, 2018

It does seem to work for me now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgrinberg @yminsky