Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Dependencies in user rule outside the workspace. #4034

Closed
bobot opened this issue Dec 14, 2020 · 1 comment
Closed

[RFC] Dependencies in user rule outside the workspace. #4034

bobot opened this issue Dec 14, 2020 · 1 comment
Labels
accepted accepted proposals
Milestone

Comments

@bobot
Copy link
Collaborator

bobot commented Dec 14, 2020

Expected Behavior

  • Don't raise an exception ;) already the case
  • Support it? by being like external path.

Actual Behavior

Using a path outside the workspace is not well supported nor checked:

  • using %{dep:/home/user/foo.txt} raise an exception when translating it to internal path (failed only for <= 2.7)
  • using %{dep:../foo.txt} in a dune file at the root of the workspace is accepted even if it corresponds to _build/foo.txt.
  • using %{dep:../../foo.txt} in a dune file at the root of the workspace is refused with a nice message.

Reproduction

Tests in #4035

Additional information

I would have wanted to support such user dependencies (backtracking/mlpost#14), as we do for absolute path:

  • we can support the relative path in rule dependencies.
  • and support it in copy_files stanza.

(EDIT: absolute path works in dev)

@bobot
Copy link
Collaborator Author

bobot commented Jan 26, 2022

Meeting:

  • Ok: consider them as absolute external path

@rgrinberg rgrinberg added the accepted accepted proposals label Jan 26, 2022
@rgrinberg rgrinberg added this to the 3.2.0 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted proposals
Projects
None yet
Development

No branches or pull requests

2 participants