Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate public_name field leads to poor error message #661

Closed
agarwal opened this issue Mar 28, 2018 · 1 comment
Closed

duplicate public_name field leads to poor error message #661

agarwal opened this issue Mar 28, 2018 · 1 comment

Comments

@agarwal
Copy link
Member

agarwal commented Mar 28, 2018

If you have two jbuild files with (name mylib), you get a nice error message:

Library "mylib" is defined twice:
- mylib/a/jbuild:3
- mylib/b/jbuild:3
make: *** [dev] Error 1

However, if you mistakenly have the same public_name in multiple jbuild files, you get the following unhelpful error:

Error: exception Invalid_argument("Map.of_list_exn")
Backtrace:
Raised at file "pervasives.ml", line 33, characters 20-45
Called from file "src/scope.ml", line 74, characters 8-204
Called from file "src/super_context.ml", line 89, characters 4-103
Called from file "src/gen_rules.ml", line 1205, characters 6-204
Called from file "src/fiber/fiber.ml", line 359, characters 6-13
make: *** [dev] Error 1
@ghost ghost closed this as completed in c7b9c2c Mar 29, 2018
@ghost
Copy link

ghost commented Mar 29, 2018

It should be fixed now. Thanks for the report.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant