Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent interfaces when depending on opam lsp package #259

Closed
SquidDev opened this issue Oct 16, 2020 · 2 comments · Fixed by #260
Closed

Inconsistent interfaces when depending on opam lsp package #259

SquidDev opened this issue Oct 16, 2020 · 2 comments · Fixed by #260

Comments

@SquidDev
Copy link
Contributor

Now that lsp is on opam (#243), I thought I should switch my project to that. However, attempting to build the project errors with the following message:

$ dune build @install
Error: Files $HOME/.opam/4.08.1/lib/lsp/lsp.cmxa
       and $HOME/.opam/4.08.1/lib/uutf/uutf.cmxa
       make inconsistent assumptions over interface Uutf

I believe this is because lsp depends on a vendored uutf package, while I depend on several libraries (alcotest, odoc) which in turn depend on opam's version of uutf.

I understand why you want to vendor dependencies for the main language server, but it's definitely less ideal for the lsp library itself. I'm not sure what the appropriate solution is here - the obvious thing to do would be to have lsp as a separate repository without vendored dependencies, and vendor it into this project, but I realise that adds a substantial maintenance burden.

This may fall under the scope of #178, apologies if so!

@rgrinberg
Copy link
Member

Yes indeed. We should unvendor uutf for the LSP library. I'll send a PR

@SquidDev
Copy link
Contributor Author

Wonderful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants