Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight incorrect for comments in unit ( (* comments in unit *) ) #1209

Closed
arbipher opened this issue Aug 31, 2023 · 3 comments
Closed

Comments

@arbipher
Copy link

( (* comments in unit *) ) in vscode will be highlighted instead of turning grey as other comments.

I am unclear if it's a problem of this extension or ocaml-lsp.

@mnxn
Copy link
Collaborator

mnxn commented Sep 19, 2023

Since the problem disappears when semantic highlighting is disabled in VS Code (using the editor.semanticHighlighting.enabled setting), the issue is with ocaml-lsp's semantic highlighting implementation.

You should create an issue in the ocaml-lsp repository if you haven't already.

@arbipher
Copy link
Author

Sure. I will create it soon later. Also, thanks for sharing the setting on how I can find the root cause.

@rgrinberg
Copy link
Contributor

Fixed in ocamllsp. Thanks!

@rgrinberg rgrinberg closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants