Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store snapshot of asset timeout into ProviderData and validity based on this timeout #580

Open
soonhuat opened this issue Nov 3, 2022 · 0 comments · May be fixed by #585
Open

Store snapshot of asset timeout into ProviderData and validity based on this timeout #580

soonhuat opened this issue Nov 3, 2022 · 0 comments · May be fixed by #585
Assignees
Labels
Type: Bug Something isn't working Type: Enhancement New feature or request

Comments

@soonhuat
Copy link
Contributor

soonhuat commented Nov 3, 2022

Is your feature request related to a problem? Please describe.
Today (03-11-2022), asset validity is calculated as order timestamp + asset/DDO timeout against current timestamp, thus, would be disaster to the data buyer if:

  1. 03-11-2022, Data buyer X but Asset A without timeout of 1 month.
  2. Downloaded the Data A.
  3. 04-11-2022, Asset A owner edit the metadata and changed the timeout from 1 month to 1 day.
  4. 05-11-2022, Data buyer X order would be expired because is based on the last asset/DDO timeout.

Describe the solution you'd like
As per previous discussion with @alexcos20 , while provider/initialize or provider/initalizeCompute, provider could store either the current Asset/DDO timeout or the expiry timestamp in ProviderData.

Additional context
Market/provider would display/calculate validity based on order timestamp + ProviderData Asset timeout or the expiry timestamp.

@alexcos20

@soonhuat soonhuat added the Type: Enhancement New feature or request label Nov 3, 2022
@LoznianuAnamaria LoznianuAnamaria added Type: Bug Something isn't working Type: Enhancement New feature or request and removed Type: Enhancement New feature or request Type: Bug Something isn't working labels Dec 5, 2022
@alexcos20 alexcos20 transferred this issue from oceanprotocol/pm Dec 8, 2022
@alexcos20 alexcos20 linked a pull request Dec 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants