Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credetials is not enforced, at least in the case of an algorithm #657

Closed
rogargon opened this issue Aug 9, 2023 · 1 comment · Fixed by #667
Closed

Credetials is not enforced, at least in the case of an algorithm #657

rogargon opened this issue Aug 9, 2023 · 1 comment · Fixed by #667
Assignees
Labels
Priority: High Type: Bug Something isn't working

Comments

@rogargon
Copy link

rogargon commented Aug 9, 2023

Describe the bug

After publishing an algorithm and restricting its use using the credentials feature:

{
"allow": [
{
"type": "address",
"values": ["0x620...6822"]
}
],
"deny": []
}

The credentials are not enforced and the algorithm can be run by other users different from the allowed one.

To Reproduce
Tested in the context of the Pontus-X project which uses as default provider https://provider.v4.genx.delta-dao.com, which is on version 1.3.12.

The algorithm was published using the Nautilus library, which allows to set the credentials restriction programmatically, as it is not available from the Market front end.

Not able to test if this issue is still present in version 2.1.0, though I've been unable to find any issue related to this problem addressed from version 1.3.12.

Expected behavior
Just the users explicitly granted access through credentials can execute the algorithm.

@LoznianuAnamaria
Copy link

@mariacarmina Once we fix this, let's test how the market behaves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants