Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code styling #232

Closed
ChillarAnand opened this issue Jul 16, 2017 · 3 comments
Closed

Improve code styling #232

ChillarAnand opened this issue Jul 16, 2017 · 3 comments

Comments

@ChillarAnand
Copy link
Contributor

ChillarAnand commented Jul 16, 2017

c

It is hard to read code in editors as it is not formatted correctly. We can use tools like autopep8, yapf to automatically fix those issues.

Also, add flake8 to Travis.

@zuphilip zuphilip changed the title Imporve code styling Improve code styling Jul 16, 2017
@zuphilip
Copy link
Collaborator

zuphilip commented Jul 16, 2017

PEP8 coding style sounds generally good for me. But I think this would involve in a huge amount of changes through all files. Some time ago I started to add more unit tests to increase also coverage and I would feel more save when we have them in place, before improving coding style. Moreover, we also have some issues with imports, I certainly would like to fix first, see #206.

@tmbdev, @kba, @QuLogic, @amitdo, what do you think about PEP8 coding style?

@zuphilip
Copy link
Collaborator

zuphilip commented Aug 4, 2017

(moved unrelated comments by @Christophered to temporarily place https://gist.github.com/zuphilip/6dabb222b6fcd4c2663ba0d9e796a915 )

@ocropus-archive ocropus-archive deleted a comment Aug 8, 2017
@zuphilip
Copy link
Collaborator

Some of the issues about the coding style should be improved. If you encounter anything specific which should be urgently improved then just let us know, or create a PR. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants