Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore warnings as errors in CI #431

Closed
aantron opened this issue Jul 2, 2017 · 2 comments
Closed

Restore warnings as errors in CI #431

aantron opened this issue Jul 2, 2017 · 2 comments

Comments

@aantron
Copy link
Collaborator

aantron commented Jul 2, 2017

Until the Jbuilder port (#374), we ran the OCaml compiler with all warnings as errors in CI. This was done by setting LWT_WARNINGS_AS_ERRORS=yes in .travis.yml and appveyor.yml, and using myocamlbuild.ml to check for this environment variable, and add -warn-error +A to compiler command lines.

Ideally, we would restore this behavior under Jbuilder.
@aantron aantron added the medium label Jul 2, 2017
@andrewray
Copy link
Contributor

There is a --dev argument to jbuilder which I think is much the same thing. The targets in the makefile (and any CI scripts) should probably use it.

@aantron
Copy link
Collaborator Author

aantron commented Jul 7, 2017

Ok thanks, looking at it.

@aantron aantron closed this as completed in 3606225 Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewray @aantron