Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown attribute type on source element #229

Closed
Julow opened this issue Dec 17, 2018 · 1 comment
Closed

Unknown attribute type on source element #229

Julow opened this issue Dec 17, 2018 · 1 comment

Comments

@Julow
Copy link
Contributor

Julow commented Dec 17, 2018

The type attribute is not recognized (Error: Unknown attribute in HTML element: type) in

<source src="foo.mp3" type="audio/mpeg">
@Drup
Copy link
Member

Drup commented Dec 18, 2018

The associated attribute is Html.a_mime_type (there are several distinct type attribute, so it's disambiguated. Apparently, we are missing a smart constructor for the source html element in the ppx.

@Drup Drup closed this as completed in 731ea42 Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Drup @Julow