fix: return unique repositories only #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
commented
Sep 29, 2022
| // return array with unique repositories based by id (https://stackoverflow.com/a/56757215) | ||
| return resolvedRepositories.filter((repo, index, repoList) => repoList.findIndex(v2 => (v2.id === repo.id)) === index); | ||
| // return array with unique repositories based by name (https://stackoverflow.com/a/56757215) | ||
| return resolvedRepositories.filter((repo, index, repoList) => repoList.findIndex(v2 => (v2.name === repo.name)) === index); |
There was a problem hiding this comment.
I changed id to name to make the test passing. However, I think we should use eitherfull_name or id here to avoid situations where repo names are the same in different organisations. Doing so will result in a slightly bigger refactoring (mainly around tests) so wanted to discuss it first. What do you think @gr2m
There was a problem hiding this comment.
I'd definitely prefer to compare by id, can you do a follow up issue?
gr2m
approved these changes
Sep 29, 2022
|
🎉 This PR is included in version 3.4.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that Octoherd runs multiple times on the same repository even the code was written in a way to actual prevent this. The current implementation doesn't work, because
resolvedRepositoriesis an array of objects likebut the current implementation can deal with primitive types like number , string , boolean only.
Before
After