Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octokit::RateLimit fields are all nil after a Octokit::TooManyRequests exception #1400

Closed
andyw8 opened this issue Feb 8, 2022 · 3 comments · Fixed by #1533
Closed

Octokit::RateLimit fields are all nil after a Octokit::TooManyRequests exception #1400

andyw8 opened this issue Feb 8, 2022 · 3 comments · Fixed by #1533
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@andyw8
Copy link
Contributor

andyw8 commented Feb 8, 2022

I'm trying to call RateLimit#context (as added in #1270) but the fields are all nil:

[2] pry(#<GithubClient>)> e
=> #<Octokit::TooManyRequests: GET https://api.github.com/search/issues?[...]: 403 - API rate limit exceeded for user ID 12345. // See: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting>
[3] pry(#<GithubClient>)> e.context
=> #<struct Octokit::RateLimit limit=nil, remaining=nil, resets_at=nil, resets_in=nil>

Running v4.22.0 (against GitHub Enterprise, in case that matters).

@timrogers timrogers added the bug label Apr 26, 2022
@ghost
Copy link

ghost commented Sep 27, 2022

Any update on this issue?

@timrogers
Copy link
Contributor

Hi @moiseya ! This isn't something we have looked at yet. You'd be welcome to take a look and try to come up with a fix if you have time.

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed bug labels Oct 28, 2022
@nickfloyd nickfloyd moved this to 🔥 Backlog in 🧰 Octokit Active Dec 5, 2022
@nickfloyd nickfloyd added the Status: Up for grabs Issues that are ready to be worked on by anyone label Jan 13, 2023
@DougEdey
Copy link
Contributor

This one bit me today, I've done everything that I can in the PR above

@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants