Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to @vercel/ncc instead of the deprecated @zeit/ncc #250

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

kfcampbell
Copy link
Member

Fixes #248.

request-action releases have been failing since January as a consequence of updating semantic-release to v20.

This PR switches to the latest version of ncc as mentioned by Gregor here. Thanks Gregor!

@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 1, 2023
@gr2m gr2m merged commit 352d2ae into main Jun 1, 2023
@gr2m gr2m deleted the vercel-ncc branch June 1, 2023 19:23
@gr2m
Copy link
Contributor

gr2m commented Jun 1, 2023

only realized after merging: I wouldn't make this a fix: , because it's not a fix relevant to users. I'd use ci(release): ... for something like this

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 2.1.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kfcampbell
Copy link
Member Author

Understood, I'll change that next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Request Dependency Updates for dcl-node-runtime and vm
3 participants