Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GraphQL): add type documentation for query and operationName #662

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

klippx
Copy link
Contributor

@klippx klippx commented Jan 31, 2025

Resolves #406

Requires octokit/graphql.js#629 to be merged


Before the change?

  • operationName and query is not documented by types 🚫

After the change?

  • operationName and query is documented by types ✅

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features) NOT NEEDED
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@klippx klippx changed the title Add type documentation for query and operationName Add type documentation for query and operationName Jan 31, 2025
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 changed the title Add type documentation for query and operationName feat(GraphQL): add type documentation for query and operationName Jan 31, 2025
@wolfy1339 wolfy1339 merged commit bb399b2 into octokit:main Jan 31, 2025
6 checks passed
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 13.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@klippx klippx deleted the operation-name branch January 31, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants