Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite tests in TypeScript and Jest #187

Closed
gr2m opened this issue Aug 6, 2020 · 4 comments · Fixed by #188
Closed

Rewrite tests in TypeScript and Jest #187

gr2m opened this issue Aug 6, 2020 · 4 comments · Fixed by #188
Assignees
@wolfy1339
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only

Comments

@gr2m
Copy link
Contributor

gr2m commented Aug 6, 2020

this is a follow up to #113

@dominguezcelada do you want to take this one?
@gr2m gr2m added typescript Relevant to TypeScript users only Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Aug 6, 2020
@wolfy1339 wolfy1339 mentioned this issue Aug 6, 2020
Merged
@gr2m
Copy link
Contributor Author

gr2m commented Aug 6, 2020

@wolfy1339 is working on it: #188

@oscard0m
Copy link
Member

oscard0m commented Aug 6, 2020

@wolfy1339 is working on it: #188

If you need help let me know! 💪

@gr2m
Copy link
Contributor Author

gr2m commented Aug 16, 2020

make sure to set "testEnvironment": "node", in package.json's "jest" key, otherwise the .unref() here will cause an error

webhooks.js/src/middleware/middleware.ts

Line 58 in dfdfc46

}, 9000).unref();

gr2m referenced this issue in probot/probot Aug 16, 2020
@gr2m
test: fix jest configuration
073d1b5 
see https://github.com/octokit/webhooks.js/issues/187\#issuecomment-674500239
gr2m referenced this issue in probot/probot Aug 18, 2020
@gr2m
test: fix jest configuration
fccccc0 
see https://github.com/octokit/webhooks.js/issues/187\#issuecomment-674500239
@gr2m gr2m closed this as completed in #188 Aug 25, 2020
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 7.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfy1339 wolfy1339

Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tests): Convert to typescript and use Jest octokit/webhooks.js
3 participants
@gr2m @oscard0m @wolfy1339