fix(typescript): workaround for trouble with aggregate-error type exports (#245) #270
Conversation
gr2m
added
Type: Bug
I use |
|
@dominguezcelada are you happy with these changes? @robcresswell can you please check if that resolves #245 for you? To test this PR, you can |
|
Tested by throwing that bundle into my node_modules. Looks good 🌟 |
|
Tested in a local repo I was playing with. Running I created a new issue to make sure we do a followup on this (since the existing one will be closed when we merge this): #271 |
| @@ -47,3 +46,12 @@ export interface WebhookEventHandlerError extends AggregateError<WebhookError> { | |||
| */ | |||
| errors: WebhookError[]; | |||
| } | |||
|
|
|||
| declare class AggregateError<T extends Error = Error> | |||
There was a problem hiding this comment.
Even though is a temporary fix, we should mention and give credit to the original repo? #248 (comment) @gr2m
There was a problem hiding this comment.
oopsies sorry I missed your comment. You are right. I'll send a follow up pR
|
🎉 This PR is included in version 7.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* master: build(deps-dev): bump typescript from 4.0.2 to 4.0.3 build(deps): bump debug from 4.1.1 to 4.2.0 build(deps-dev): bump ts-jest from 26.3.0 to 26.4.0 build(types): add credit and license information for `aggregate-error` (#272) fix(typescript): workaround for trouble with aggregate-error type exports (#245) (#270) build(deps-dev): bump @types/node from 14.10.3 to 14.11.1 build(deps-dev): bump semantic-release from 17.1.1 to 17.1.2 build(deps-dev): bump @types/jest from 26.0.13 to 26.0.14 (#264) build(deps-dev): bump @types/node from 14.10.2 to 14.10.3 (#265) build(deps-dev): bump @types/node from 14.10.1 to 14.10.2 (#262) build(deps-dev): bump prettier from 2.1.1 to 2.1.2 (#263) build(deps-dev): bump @types/prettier from 2.1.0 to 2.1.1 build(deps-dev): bump @octokit/webhooks-definitions from 3.12.0 to 3.13.0 build(deps-dev): bump @types/node from 14.10.0 to 14.10.1
resolves #245
resolves #270
thanks @andrewbranch /cc @dominguezcelada