Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefix error messages with "[@octokit/webhooks] " #339

Merged
merged 2 commits into from
Oct 27, 2020
Merged

fix: prefix error messages with "[@octokit/webhooks] " #339

merged 2 commits into from
Oct 27, 2020

Conversation

srujandeshpande
Copy link
Contributor

@srujandeshpande srujandeshpande commented Oct 26, 2020 •
edited by markdownify bot
Loading

Fixes #325

Prefixed all error messages with "[@octokit/webhooks] "
middleware-test.ts was modified to expect the new error.

View rendered src/event-handler/README.md

@gr2m gr2m added the Type: Bug Something isn't working as documented, or is being fixed label Oct 26, 2020
gr2m
gr2m requested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this Srujan! There are a few changes I'd like you to revert. I'm sorry we should have made the instructions more clear. We only need to add the [@octokit/webhooks] prefix to *.ts files in the src/ folder

test/integration/event-handler-test.ts Outdated Show resolved Hide resolved
src/event-handler/README.md Outdated Show resolved Hide resolved
gr2m
gr2m approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thank you! 💐

@gr2m gr2m changed the title Prefix error messages with "[@octokit/webhooks] " fix: prefix error messages with "[@octokit/webhooks] " Oct 27, 2020
@gr2m gr2m merged commit 79cfd19 into octokit:master Oct 27, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix error messages with "[@octokit/webhooks] "
2 participants
@srujandeshpande @gr2m