fix(typescript): mark verify parameters as required
#373
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
dont-mark-params-as-optional
branch
5 times, most recently
from
3443749 to
203305c
Compare
G-Rath
force-pushed
the
dont-mark-params-as-optional
branch
from
203305c to
4fb1a78
Compare
G-Rath
commented
Dec 4, 2020
| const matchesSignature = verify(state.secret, event.payload, event.signature); | ||
| // verify will validate that the secret is not undefined | ||
| const matchesSignature = verify( | ||
| state.secret!, |
There was a problem hiding this comment.
I'm typically not a fan of using ! - ideally I'd have an assertion here about the state.secret, but tbh this isn't the worse use of it 🤷
There was a problem hiding this comment.
We are all still figuring out the whole TypeScript thing, we got much better at it since we migrated @octokit/webhooks, but there is surely lots of potential of improvement :)
There was a problem hiding this comment.
No problem - I'm a big TS fan myself, so happy to help and be pinged on things :)
gr2m
added
Type: Bug
|
🎉 This PR is included in version 7.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters for
verifyare not optional - this matches the pattern used forsign.