Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for removing onAny listener #415

Closed
billyvg opened this issue Jan 29, 2021 · 1 comment · Fixed by #416
Closed

Add docs for removing onAny listener #415

billyvg opened this issue Jan 29, 2021 · 1 comment · Fixed by #416
Assignees
@wolfy1339
Labels
Type: Bug Something isn't working as documented, or is being fixed

Comments

@billyvg
Copy link

billyvg commented Jan 29, 2021

onAny was added by #324, but there's no documentation on how to remove the listener. In order to do so, you need to call removeListener() with * as the event name.
@billyvg billyvg added the Type: Support Any questions, information, or general needs around the SDK or GitHub APIs label Jan 29, 2021
@wolfy1339 wolfy1339 added documentation Type: Bug Something isn't working as documented, or is being fixed and removed Type: Support Any questions, information, or general needs around the SDK or GitHub APIs labels Jan 29, 2021
@wolfy1339 wolfy1339 self-assigned this Jan 29, 2021
@wolfy1339
Copy link
Member

Thanks for bringing this to our attention.
I will make sure to add the proper docs

@wolfy1339 wolfy1339 linked a pull request Jan 29, 2021 that will close this issue
docs: add the information on how to remove the onAny() & onError() event handlers #416
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfy1339 wolfy1339

Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
None yet
Milestone
No milestone
2 participants
@billyvg @wolfy1339