From eb2a3b22916374b1de8d26aceb5b96db8bf7346a Mon Sep 17 00:00:00 2001 From: Oscar Dominguez Date: Sat, 8 Aug 2020 12:36:42 +0200 Subject: [PATCH 1/2] test(middlewares): fix typing of unit test for middlewares --- test/unit/middleware-test.ts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/test/unit/middleware-test.ts b/test/unit/middleware-test.ts index 494400b2..aec1ee5d 100644 --- a/test/unit/middleware-test.ts +++ b/test/unit/middleware-test.ts @@ -1,4 +1,4 @@ -import simple from "simple-mock"; +import { IncomingMessage, ServerResponse } from "http"; import { middleware } from "../../src/middleware/middleware"; import { State } from "../../src/types"; @@ -7,8 +7,14 @@ const state: State = { }; test("next() callback", () => { - const next = simple.spy(() => {}); + const next = jest.fn(); - middleware(state, { method: "POST", url: "/foo" }, {}, next); - expect(next.callCount).toBe(1); + middleware( + state, + { method: "POST", url: "/foo" } as IncomingMessage, + {} as ServerResponse, + next + ); + + expect(next).toBeCalledTimes(1); }); From c7e9e3f4481f6342fc11bf0fd01d15e88c878271 Mon Sep 17 00:00:00 2001 From: Oscar Dominguez Date: Sat, 8 Aug 2020 12:55:00 +0200 Subject: [PATCH 2/2] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20refactor(jest):=20use?= =?UTF-8?q?=20toHaveBeenCalled=20instead=20of=20toHaveBeenCalledTimes(1)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test/unit/middleware-test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/middleware-test.ts b/test/unit/middleware-test.ts index aec1ee5d..687a5739 100644 --- a/test/unit/middleware-test.ts +++ b/test/unit/middleware-test.ts @@ -16,5 +16,5 @@ test("next() callback", () => { next ); - expect(next).toBeCalledTimes(1); + expect(next).toHaveBeenCalled(); });