-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Inconsistent types on WebHook models #524
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Looking forward to version 3 soon then, thank you for the quick fix! |
What happened?
Different types exposes similar properties using different underlying types, I was looking at the
*_at
properties in the classWorkflowJob and seems like those properties are exposed as string while most of the time they're exposes as
DateTimeOffset
.Having a quick look here I found some more occurrences here and here
Can we unify those and use
DateTimeOffset
everywhere? This will be a breaking change so it requires a major version bump.Versions
2.2.2
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: